Messages in this thread | | | Date | Mon, 30 Jan 2012 16:11:16 +0000 | From | Mark Brown <> | Subject | Re: [RFC 2/2] regmap: make use of cached entries in debugfs |
| |
On Mon, Jan 30, 2012 at 04:34:27PM +0100, Wolfram Sang wrote: > On Mon, Jan 30, 2012 at 02:56:28PM +0000, Mark Brown wrote:
> > > - if (!regmap_readable(map, i)) > > > + if (map->cache_type == REGCACHE_NONE && !regmap_readable(map, i))
> > This isn't quite what you said in the changelog
> Sorry, I reread and can't find the diff?
Oh, right, you're not actually saying you'll only give cached values back - my mistake.
> > and isn't going to play nicely with sparse register maps
> sparse == RBTREE? What does "play nicely" mean here? Too slow?
A sparse register map is one that doesn't contain all possible register addresses, it's orthogonal to the cache - you can have an uncached device where we know some addresses don't exist or for a cached device the cache could be any type.
The check for regmap_readable() is there because it causes the debugfs code to not display registers that don't exist, otherwise we could easily DoS the output to the point of illegibility by including large numbers (potentially thousands) of nonexistant registers in the output making it hard for humans to find the ones that actually exist.
> > - it should be
> > if (regmap_cached(map, i) || regmap_readable(map, i))
> > or so (regmap_cached() doesn't exist at present but it seems reasonable > > that it should).
> Sigh, I have to give up for now. Sadly, I am already way beyond my > schedule regarding the amplifier driver and need to work on other things > now.
Oh well. I might get round to it sometime but essentially all the chips I work with have read/write support so the issue never comes up. [unhandled content-type:application/pgp-signature] | |