Messages in this thread | | | Date | Thu, 19 Jan 2012 16:25:43 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: [Update][PATCH] PM / Hibernate: Fix s2disk regression related to unlock_system_sleep() |
| |
On 01/19/2012 04:07 PM, Pavel Machek wrote:
> Hi! > >>>> I agree, but I was trying to keep the comment from growing too long ;) >>> >>> It doesn't have to be long. It just has to give some meaning to the >>> decision. AFAICS, it is correct to call try_to_freeze() on >>> unlock_system_sleep() regardless of 20sec window. There's no >>> guarantee the unlocking task is gonna hit try_to_freeze() elsewhere >>> and not calling it actually makes the interface buggy. >> >> To give an example, >> >> /* >> * XXX: Open code SKIP clearing for now to avoid invoking >> * try_to_freeze(). This isn't correct but this function is >> * called from deep inside hibernation path and calling >> * try_to_freeze() leads to hang during hibernation. This >> * will be properly fixed soon. See commit message for >> * more details. >> */ > > Which paths are affected? > > With uswsusp, we have userland in control of hibernation process; I'd > say almost anything can be called...
Hi Pavel, I am afraid you are looking at a stale comment. We finalized on a different comment altogether.
Here is the latest patch: http://thread.gmane.org/gmane.linux.kernel/1240493/focus=1240976
Rafael made some suggestions on this one here http://thread.gmane.org/gmane.linux.kernel/1240493/focus=1241028
I will address that and send out a patch soon.
Do let me know if you have any comments, thanks!
Regards, Srivatsa S. Bhat
| |