lkml.org 
[lkml]   [2012]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Update][PATCH] PM / Hibernate: Fix s2disk regression related to unlock_system_sleep()
    Hi!

    > > > I agree, but I was trying to keep the comment from growing too long ;)
    > >
    > > It doesn't have to be long. It just has to give some meaning to the
    > > decision. AFAICS, it is correct to call try_to_freeze() on
    > > unlock_system_sleep() regardless of 20sec window. There's no
    > > guarantee the unlocking task is gonna hit try_to_freeze() elsewhere
    > > and not calling it actually makes the interface buggy.
    >
    > To give an example,
    >
    > /*
    > * XXX: Open code SKIP clearing for now to avoid invoking
    > * try_to_freeze(). This isn't correct but this function is
    > * called from deep inside hibernation path and calling
    > * try_to_freeze() leads to hang during hibernation. This
    > * will be properly fixed soon. See commit message for
    > * more details.
    > */

    Which paths are affected?

    With uswsusp, we have userland in control of hibernation process; I'd
    say almost anything can be called...
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2012-01-19 11:39    [W:0.020 / U:2.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site