Messages in this thread | | | Date | Thu, 8 Sep 2011 21:24:45 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v3] Make PTRACE_SEIZE set ptrace options specified in 'data' |
| |
On 09/08, Denys Vlasenko wrote: > > Make PTRACE_SEIZE set ptrace options specified in 'data' parameter
Thanks, looks good. But we need the correct "Simplify PTRACE_foo..." first.
> Make it possible to extend SEIZE in the future with more functionality > by passing non-zero 'addr' parameter.
Agreed, this makes sense.
> Set all task->ptrace bits in one operation - before this change, > we were adding PT_SEIZED and PT_PTRACE_CAP with task->ptrace |= BIT ops. > This was probably ok (not a bug), but let's be on a safer side.
PT_PTRACE_CAP is fine, but PT_SEIZED is not really, afaics.
Oleg.
| |