Messages in this thread | | | Date | Wed, 21 Sep 2011 16:35:07 +0100 | From | Matthew Garrett <> | Subject | Re: [PATCH 1/6] toshiba_acpi: Convert to use acpi_driver |
| |
On Wed, Sep 21, 2011 at 09:28:30AM +0200, Corentin Chary wrote: > On Tue, Sep 20, 2011 at 11:55 PM, Seth Forshee > <seth.forshee@canonical.com> wrote: > > Changes toshiba_acpi to register an acpi driver and eliminates the > > platform device it was using. > > Why to you want to remove the platform device ? If you want to create > a sysfs interface later, you'll probably need it. Most of the platform > driver I know only use the acpi_device to send proc/netlink events and > the platform_device is used everywhere else. (And anyway, it's an x86 > *platform* driver, not a pure acpi driver).
There's no hard requirement for a platform device, and given that it's purely using ACPI methods it arguably *is* a pure ACPI driver - Toshiba could use the same interface on an ARM device, if they were feeling excessively enthusiastic. But I've no strong feelings either way.
-- Matthew Garrett | mjg59@srcf.ucam.org
| |