[lkml]   [2011]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/6] toshiba_acpi: Convert to use acpi_driver
On Tue, Sep 20, 2011 at 11:55 PM, Seth Forshee
<> wrote:
> Changes toshiba_acpi to register an acpi driver and eliminates the
> platform device it was using.

Why to you want to remove the platform device ? If you want to create
a sysfs interface later, you'll probably need it. Most of the platform
driver I know only use the acpi_device to send proc/netlink events and
the platform_device is used everywhere else. (And anyway, it's an x86
*platform* driver, not a pure acpi driver).

> Also eliminates most global
> variables, moving them into toshiba_acpi_dev, along with some
> other miscellaneous fixes and cleanup.

Good ! Next step would be to deprecate the /proc interface (keeping it
for compatibility) and adding a new shinny
/sys/platform/device/toshiba-acpi/ interface correctly documented in
Documentation/ABI/ :).


Corentin Chary

 \ /
  Last update: 2011-09-21 09:31    [W:0.105 / U:8.056 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site