Messages in this thread | | | Date | Wed, 21 Sep 2011 09:28:30 +0200 | Subject | Re: [PATCH 1/6] toshiba_acpi: Convert to use acpi_driver | From | Corentin Chary <> |
| |
On Tue, Sep 20, 2011 at 11:55 PM, Seth Forshee <seth.forshee@canonical.com> wrote: > Changes toshiba_acpi to register an acpi driver and eliminates the > platform device it was using.
Why to you want to remove the platform device ? If you want to create a sysfs interface later, you'll probably need it. Most of the platform driver I know only use the acpi_device to send proc/netlink events and the platform_device is used everywhere else. (And anyway, it's an x86 *platform* driver, not a pure acpi driver).
> Also eliminates most global > variables, moving them into toshiba_acpi_dev, along with some > other miscellaneous fixes and cleanup.
Good ! Next step would be to deprecate the /proc interface (keeping it for compatibility) and adding a new shinny /sys/platform/device/toshiba-acpi/ interface correctly documented in Documentation/ABI/ :).
Thanks,
-- Corentin Chary http://xf.iksaif.net
| |