lkml.org 
[lkml]   [2011]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/4] drivers/scsi/mpt2sas/mpt2sas_transport.c: take size of pointed value, not pointer
    Date
    From: Julia Lawall <julia@diku.dk>

    Sizeof a pointer-typed expression returns the size of the pointer, not that
    of the pointed data.

    The semantic patch that fixes this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    expression *e;
    type T;
    identifier f;
    @@

    f(...,(T)e,...,
    -sizeof(e)
    +sizeof(*e)
    ,...)
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    drivers/scsi/mpt2sas/mpt2sas_transport.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff -u -p a/drivers/scsi/mpt2sas/mpt2sas_transport.c b/drivers/scsi/mpt2sas/mpt2sas_transport.c
    --- a/drivers/scsi/mpt2sas/mpt2sas_transport.c
    +++ b/drivers/scsi/mpt2sas/mpt2sas_transport.c
    @@ -163,7 +163,7 @@ _transport_set_identify(struct MPT2SAS_A
    return -EIO;
    }

    - memset(identify, 0, sizeof(identify));
    + memset(identify, 0, sizeof(*identify));
    device_info = le32_to_cpu(sas_device_pg0.DeviceInfo);

    /* sas_address */


    \
     
     \ /
      Last update: 2011-09-16 09:01    [W:0.020 / U:0.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site