lkml.org 
[lkml]   [2011]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] workqueue: Restore cpus_allowed mask for sleeping workqueue rescue threads
Date
Rescuer threads may be migrated (and are bound) to particular CPUs when
active. However, the allowed_cpus mask is not restored when they return
to sleep rendering inconsistent the presented and actual set of CPUs the
process may potentially run on. This patch fixes this oversight by
recording the allowed_cpus mask for rescuer threads when it enters the
rescuer_thread() main loop and restoring it every time the thread sleeps.

v2: Heeded Peter Zijlstra's comments and don't allocate cpumask_t on
stack, manipulate task cpus_allowed struct directly instead

Signed-off-by: Ripduman Sohan <ripduman.sohan@cl.cam.ac.uk>
---
kernel/workqueue.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 25fb1b0..29d2ddf 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -2078,6 +2078,12 @@ repeat:
spin_unlock_irq(&gcwq->lock);
}

+ if (is_unbound)
+ cpumask_setall(&current->cpus_allowed);
+ else
+ for_each_cwq_cpu(cpu, wq)
+ cpu_set(cpu, current->cpus_allowed);
+
schedule();
goto repeat;
}
--
1.7.1


\
 
 \ /
  Last update: 2011-09-01 15:39    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site