Messages in this thread Patch in this message | | | From | "Rafael J. Wysocki" <> | Subject | [PATCH] sh: Fix boot crash related to SCI | Date | Mon, 8 Aug 2011 00:26:50 +0200 |
| |
From: Rafael J. Wysocki <rjw@sisk.pl>
Commit d006199e72a9cf9537ff567ffa07c3f343b9182a (serial: sh-sci: Regtype probing doesn't need to be fatal.) made sci_init_single() return when sci_probe_regmap() succeeds, although it should return when sci_probe_regmap() fails. This causes systems using the serial sh-sci driver to crash during boot.
Fix the problem by using the right return condition.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- drivers/tty/serial/sh-sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/drivers/tty/serial/sh-sci.c =================================================================== --- linux-2.6.orig/drivers/tty/serial/sh-sci.c +++ linux-2.6/drivers/tty/serial/sh-sci.c @@ -1889,7 +1889,7 @@ static int __devinit sci_init_single(str if (p->regtype == SCIx_PROBE_REGTYPE) { ret = sci_probe_regmap(p); - if (unlikely(!ret)) + if (unlikely(ret)) return ret; }
| |