Messages in this thread Patch in this message | | | Date | Fri, 5 Aug 2011 17:18:21 +0300 | From | Dan Carpenter <> | Subject | [patch] xen-blkback: add missing return on error in xen_update_blkif_status() |
| |
We should return here after reporting the error. Otherwise we'd hit a NULL deref of blkif->xenblkd on the next line.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 32d4c3c..b750299 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -107,6 +107,7 @@ static void xen_update_blkif_status(struct xen_blkif *blkif) err = PTR_ERR(blkif->xenblkd); blkif->xenblkd = NULL; xenbus_dev_error(blkif->be->dev, err, "start xenblkd"); + return; } blkif->be->kthread_pid = blkif->xenblkd->pid;
| |