Messages in this thread | | | Date | Thu, 4 Aug 2011 14:12:49 +0530 | From | viresh kumar <> | Subject | Re: [PATCH V2 08/20] dmaengine/amba-pl08x: support runtime PM |
| |
On 08/04/2011 12:58 PM, Koul, Vinod wrote: >> > >> > Until this point we are not touching the registers at all. And they will >> > accessed after this point only. > But from maintainability POV it should be at the start. >
Sorry for missing this earlier, I looked at the code again and realized why i put it at the end of the routine.
The routine looks like this
for (all channels) if (!ch->serving) break;
if (i == pl08x->vd->channels) { /* No physical channel available, cope with it */ return NULL; }
pm_runtime_get_sync(&pl08x->adev->dev);
So, this has to be put at end only. We don't want to call this if no physical channel is free.
-- viresh
| |