lkml.org 
[lkml]   [2011]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 08/20] dmaengine/amba-pl08x: support runtime PM
On 08/04/2011 12:58 PM, Koul, Vinod wrote:
>> >
>> > Until this point we are not touching the registers at all. And they will
>> > accessed after this point only.
> But from maintainability POV it should be at the start.
>

Sorry for missing this earlier, I looked at the code again and
realized why i put it at the end of the routine.

The routine looks like this

for (all channels)
if (!ch->serving)
break;

if (i == pl08x->vd->channels) {
/* No physical channel available, cope with it */
return NULL;
}

pm_runtime_get_sync(&pl08x->adev->dev);

So, this has to be put at end only. We don't want to call this if no physical
channel is free.

--
viresh


\
 
 \ /
  Last update: 2011-08-04 10:45    [W:0.070 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site