Messages in this thread Patch in this message | | | Subject | [PATCH] tpm: tpm_nsc: Fix a double free of pdev in cleanup_nsc | From | Axel Lin <> | Date | Thu, 04 Aug 2011 07:58:07 +0800 |
| |
platform_device_unregister() will release all resources and remove it from the subsystem, then drop reference count by calling platform_device_put().
We should not call kfree(pdev) after platform_device_unregister(pdev).
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/char/tpm/tpm_nsc.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_nsc.c b/drivers/char/tpm/tpm_nsc.c index 82facc9..4d24648 100644 --- a/drivers/char/tpm/tpm_nsc.c +++ b/drivers/char/tpm/tpm_nsc.c @@ -396,8 +396,6 @@ static void __exit cleanup_nsc(void) if (pdev) { tpm_nsc_remove(&pdev->dev); platform_device_unregister(pdev); - kfree(pdev); - pdev = NULL; } platform_driver_unregister(&nsc_drv); -- 1.7.4.1
| |