Messages in this thread | | | Date | Mon, 29 Aug 2011 09:47:08 +0200 | Subject | Re: [PATCH] tpm: TCG_ATMEL should depend on HAS_IOPORT | From | Geert Uytterhoeven <> |
| |
On Mon, Aug 8, 2011 at 13:08, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On m68k, I get: > > drivers/char/tpm/tpm_atmel.h: In function ‘atmel_get_base_addr’: > drivers/char/tpm/tpm_atmel.h:129: error: implicit declaration of function ‘ioport_map’ > drivers/char/tpm/tpm_atmel.h:129: warning: return makes pointer from integer without a cast > > The code in tpm_atmel.h supports PPC64 (using the device tree and ioremap()) > and "anything else" (using ioport_map()). However, ioportmap() is only > available on platforms that set HAS_IOPORT. > > Although PC64 seems to have HAS_IOPORT, a "depends on HAS_IOPORT" should work,
Since ...
> but I think it's better to expose the special PPC64 handling explicit using
... explicitly ...
> "depends on PPC64 || HAS_IOPORT". > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > drivers/char/tpm/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig > index f6595ab..fa567f1 100644 > --- a/drivers/char/tpm/Kconfig > +++ b/drivers/char/tpm/Kconfig > @@ -43,6 +43,7 @@ config TCG_NSC > > config TCG_ATMEL > tristate "Atmel TPM Interface" > + depends on PPC64 || HAS_IOPORT > ---help--- > If you have a TPM security chip from Atmel say Yes and it > will be accessible from within Linux. To compile this driver > -- > 1.7.0.4
Ping? M68k allmodconfig breakage in 3.1-rc*.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |