Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] tpm: TCG_ATMEL should depend on HAS_IOPORT | Date | Mon, 29 Aug 2011 13:19:53 +0200 |
| |
On Monday 08 August 2011, Geert Uytterhoeven wrote: > drivers/char/tpm/tpm_atmel.h: In function ‘atmel_get_base_addr’: > drivers/char/tpm/tpm_atmel.h:129: error: implicit declaration of function ‘ioport_map’ > drivers/char/tpm/tpm_atmel.h:129: warning: return makes pointer from integer without a cast > > The code in tpm_atmel.h supports PPC64 (using the device tree and ioremap()) > and "anything else" (using ioport_map()). However, ioportmap() is only > available on platforms that set HAS_IOPORT. > > Although PC64 seems to have HAS_IOPORT, a "depends on HAS_IOPORT" should work, > but I think it's better to expose the special PPC64 handling explicit using > "depends on PPC64 || HAS_IOPORT". > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
FWIW, I've now got a first prototype of the HAS_IOPORT rework in http://git.kernel.org/?p=linux/kernel/git/arm/linux-arm-soc.git;a=shortlog;h=refs/heads/tmp/randconfig3 along with a lot of bug fixes for ARM. Feel free to play with that on other architectures.
Since your patch adds another use of HAS_IOPORT, I will have to rename that as well to HAS_IOPORT_MAP as I do for all the other uses.
Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |