| From | Linus Torvalds <> | Date | Wed, 24 Aug 2011 11:01:52 -0700 | Subject | Re: [PATCH 03/18] x86/ticketlock: Use C for __ticket_spin_unlock |
| |
On Wed, Aug 24, 2011 at 10:52 AM, Jeremy Fitzhardinge <jeremy@goop.org> wrote: > From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > > If we don't need to use a locked inc for unlock, then implement it in C.
Ok, so I really hate this patch.
What the f&*^ is the point of doing it this way? It just ends up being incredibly ugly, with a mixture of C, asm, and barriers. The "C" version is actually *uglier* than the non-C version, so why do it in C at all?
Just get rid of this one. It adds lines of code, makes the code harder to read, and is just a disaster.
Linus
|