lkml.org 
[lkml]   [2011]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 07/12] x86: use cmpxchg_flag() where applicable
Ok, I see nothing horrible in this series.

The one reaction I have is that the cmpxchg_flag() thing returns an
8-bit value, but then a lot of the users end up having to extend it to
a full "int" purely for calling convention reasons (eg I think
'down_write_trylock()' will have 'sete + movzl' - not a new problem,
but since the whole point was to remove extraneous instructions and we
no longer have the silly 'testl', it now annoys me more).

So it seems a bit sad. But I guess it doesn't really matter.

Linus


\
 
 \ /
  Last update: 2011-08-24 23:59    [W:0.074 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site