Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 23 Aug 2011 09:20:12 -0700 | Subject | Re: [uml-devel] SYSCALL, ptrace and syscall restart breakages (Re: [RFC] weird crap with vdso on uml/i386) |
| |
On Tue, Aug 23, 2011 at 9:11 AM, Andrew Lutomirski <luto@mit.edu> wrote: > > Egads. Does this mean that doing GETREGS and then doing SETREGS later > on with the *exact same values* is considered incorrect?
No. If it does it with exactly the same values, it's perfectly ok. But it isn't. It's changing some of those values.
> IMO, this way lies madness.
No, the madness is in UML.
It's EMULATING A SYSTEM CALL. That original "getregs" value is not some "user space state". It's the *system call* state that you got after the system call trapped. Setting it back is an insane operation, but it would happen to work - if you make no changes.
But UML *does* make changes. It takes that system call state, and then EMULATES THE SYSTEM CALL INCORRECTLY.
If you see it that way (which is the correct way), then it's clearly an UML problem, and it's not at all "madness" that your getregs/setregs pairing doesn't work.
See? Buggy system call emulation. It's really that simple. Of course, "simple" in this case is "really really subtle differences in how the kernel treats syscall/sysenter/int80", so the *details* are certainly not simple, but the concept is.
Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |