| Date | Fri, 19 Aug 2011 13:43:06 -0300 | From | Gustavo Padovan <> | Subject | Re: [PATCH 02/16] freezer: don't unnecessarily set PF_NOFREEZE explicitly |
| |
Hi Tejun,
* Tejun Heo <tj@kernel.org> [2011-08-19 16:16:08 +0200]:
> Some drivers set PF_NOFREEZE in their kthread functions which is > completely unnecessary and racy - some part of freezer code doesn't > consider cases where PF_NOFREEZE is set asynchronous to freezer > operations. > > In general, there's no reason to allow setting PF_NOFREEZE explicitly. > Remove them and change the documentation to note that setting > PF_NOFREEZE directly isn't allowed. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Marcel Holtmann <marcel@holtmann.org> > Cc: "Gustavo F. Padovan" <padovan@profusion.mobi> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: wwang <wei_wang@realsil.com.cn> > --- > Documentation/power/freezing-of-tasks.txt | 2 +- > drivers/bluetooth/btmrvl_main.c | 2 -- > drivers/mfd/twl4030-irq.c | 3 --- > drivers/mfd/twl6030-irq.c | 2 -- > drivers/staging/rts_pstor/rtsx.c | 2 -- > 5 files changed, 1 insertions(+), 10 deletions(-)
Acked-by: Gustavo F. Padovan <padovan@profusion.mobi>
Gustavo
|