lkml.org 
[lkml]   [2011]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/16] freezer: use dedicated lock instead of task_lock() + memory barrier
On 08/28, Oleg Nesterov wrote:
>
> Off-topic, but fake_signal_wake_up() is not safe if the caller
> try_to_freeze_cgroup(). Unlike try_to_freeze_tasks() (which holds
> tasklist) we can race with the exiting thread, ->sighand can be
> NULL.

Although with PF_NOFREEZE in do_exit() from 6/16, this race is only
theoretical.

And, forgot to mention, __thaw_task() looks racy too, but i think
this recalc_sigpending_and_wake() can simply go away.

Oleg.



\
 
 \ /
  Last update: 2011-08-28 20:27    [W:0.196 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site