Messages in this thread Patch in this message | | | Subject | [PATCH] Staging: rts_pstor: dont cast void* from kmalloc() | From | Thomas Meyer <> | Date | Sat, 13 Aug 2011 11:28:50 +0200 |
| |
From: Thomas Meyer <thomas@m3y3r.de>
Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14.
The semantic patch that makes this output is available in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.
More information about semantic patching is available at http://coccinelle.lip6.fr/
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> ---
diff -u -p a/drivers/staging/rts_pstor/spi.c b/drivers/staging/rts_pstor/spi.c --- a/drivers/staging/rts_pstor/spi.c 2011-05-27 19:17:05.999541117 +0200 +++ b/drivers/staging/rts_pstor/spi.c 2011-08-01 19:57:11.534038755 +0200 @@ -463,7 +463,7 @@ int spi_read_flash_id(struct scsi_cmnd * } if (len) { - buf = (u8 *)kmalloc(len, GFP_KERNEL); + buf = kmalloc(len, GFP_KERNEL); if (!buf) TRACE_RET(chip, STATUS_ERROR);
| |