lkml.org 
[lkml]   [2011]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] staging: ft1000: dont cast void* from kmalloc()
From
Date
From: Thomas Meyer <thomas@m3y3r.de>

Casting (void *) value returned by kmalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.

The semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c 2011-07-26 00:46:09.646838687 +0200
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c 2011-08-01 19:56:17.237666237 +0200
@@ -485,7 +485,7 @@ void card_send_command(struct ft1000_dev

DEBUG("card_send_command: enter card_send_command... size=%d\n", size);

- commandbuf = (unsigned char *)kmalloc(size + 2, GFP_KERNEL);
+ commandbuf = kmalloc(size + 2, GFP_KERNEL);
memcpy((void *)commandbuf + 2, (void *)ptempbuffer, size);

ft1000_read_register(ft1000dev, &temp, FT1000_REG_DOORBELL);



\
 
 \ /
  Last update: 2011-08-13 16:15    [W:0.023 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site