lkml.org 
[lkml]   [2011]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] staging: tidspbridge: dont cast void* from kmalloc()
From
Date
From: Thomas Meyer <thomas@m3y3r.de>

Casting (void *) value returned by kmalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.

The semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/drivers/staging/tidspbridge/gen/gh.c b/drivers/staging/tidspbridge/gen/gh.c
--- a/drivers/staging/tidspbridge/gen/gh.c 2011-04-14 10:34:38.600880635 +0200
+++ b/drivers/staging/tidspbridge/gen/gh.c 2011-08-01 19:58:07.230403689 +0200
@@ -55,7 +55,7 @@ struct gh_t_hash_tab *gh_create(u16 max_
hash_tab->match = match;
hash_tab->delete = delete == NULL ? noop : delete;

- hash_tab->buckets = (struct element **)
+ hash_tab->buckets =
kzalloc(sizeof(struct element *) * max_bucket, GFP_KERNEL);
if (hash_tab->buckets == NULL) {
gh_delete(hash_tab);



\
 
 \ /
  Last update: 2011-08-13 16:15    [W:0.023 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site