Messages in this thread | | | Date | Sat, 9 Jul 2011 16:57:33 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH 2/4] regmap: Add I2C bus support |
| |
On Sat, Jul 09, 2011 at 11:08:36PM +0900, Mark Brown wrote: > On Sat, Jul 09, 2011 at 01:53:07PM +0200, Wolfram Sang wrote: > > On Sat, Jul 09, 2011 at 01:50:42PM +0900, Mark Brown wrote: > > > > +#include <linux/regmap.h> > > > +#include <linux/i2c.h> > > > +#include <linux/module.h> > > > I second Lars-Peter with init.h here (from his first review). > > Remind me of what you're talking about here?
He suggested including init.h, because of the use of postcore_initcall.
That's minor, of course. But you probably need to resend anyway, because of the mangling-check in the read function.
But in general: great series! I also had played with the idea of abstracting I2C/SPI-access away. Will surely try to convert a driver myself.
Thanks,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |