Messages in this thread | | | Date | Sat, 9 Jul 2011 23:08:36 +0900 | From | Mark Brown <> | Subject | Re: [PATCH 2/4] regmap: Add I2C bus support |
| |
On Sat, Jul 09, 2011 at 01:53:07PM +0200, Wolfram Sang wrote: > On Sat, Jul 09, 2011 at 01:50:42PM +0900, Mark Brown wrote:
> > +#include <linux/regmap.h> > > +#include <linux/i2c.h> > > +#include <linux/module.h>
> I second Lars-Peter with init.h here (from his first review).
Remind me of what you're talking about here?
> > + if (!i2c_check_functionality(i2c->adapter, I2C_FUNC_PROTOCOL_MANGLING)) > > + return -ENOTSUPP;
> Even more here. MANGLING is not needed for reading (and it will fail for a > number of i2c-masters).
Huh, though I'd removed this.
| |