lkml.org 
[lkml]   [2011]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] PWM: add pwm framework support
Date
On Monday 04 July 2011, Kurt Van Dijck wrote:
> >
> > The pwm framework needs to incorporate at least the following:
> > - sysfs access (ep93xx driver)
> > - Multiple channels per device (atmel driver)
>
> These are 2 very hardware dependant additions. Is this really the job
> for a framework to incorporate this?
> IMHO, the job of a framework is to allow such things. Creating a framework
> that does all special things of all vendors makes such thing
> complicated.

I think you shouldn't make it too easy for drivers to add extra
sysfs files. If at all possible, the default should be to add
them to the core, and define them in a way that makes sense for
future similar drivers.

We need to be careful to avoid a situation where multiple driver
writers introduce the same feature with a sysfs attribute, but do
so in an incompatible way.

> With socketCAN, we encountered a similar problem. Every chip maker
> tries to create added value by means of special options. You can't
> support them all in the framework. Therefore, sysfs can be added
> to configure special things.

I would expect that pwm is much simpler than CAN, so the amount
of creativity there is also limited.

Arnd


\
 
 \ /
  Last update: 2011-07-04 15:55    [W:0.121 / U:1.084 seconds]
©2003-2014 Jasper Spaans. Advertise on this site