lkml.org 
[lkml]   [2011]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/18] dmaengine/amba-pl08x: Resolve formatting issues
From
On 7/29/11, Koul, Vinod <vinod.koul@intel.com> wrote:
> On Fri, 2011-07-29 at 16:19 +0530, Viresh Kumar wrote:
>> /*
>> * So now we know how many bytes to transfer
>> - * to get to the nearest boundary. The next
>> - * LLI will past the boundary. However, we
>> + * to get to the nearest boundary. The next
>> + * LLI will past the boundary. However, we
>> * may be working to a boundary on the slave
>> - * bus. We need to ensure the master stays
>> + * bus. We need to ensure the master stays
>> * aligned, and that we are working in
>> * multiples of the bus widths.
>> */
> This looks v ugly, care to fix this.
> 80chars should be followed with a little common sense, if it sacrifices
> code readability then pls ignore it.
> In places where you can fix it w/o sacrificing code quality pls do it :)

Ok.

>> /* FIXME: use round_down()? */
> while you are fixing the driver, care to fix the FIXME as well?

Already removed this. :)

--
viresh


\
 
 \ /
  Last update: 2011-07-29 17:27    [W:1.190 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site