Messages in this thread Patch in this message | | | Date | Wed, 13 Jul 2011 15:24:29 -0700 | From | Wu Fengguang <> | Subject | [PATCH] mm: account NR_WRITTEN at IO completion time |
| |
NR_WRITTEN is now accounted at block IO enqueue time, which is not very accurate as to common understanding. This moves NR_WRITTEN accounting to the IO completion time and makes it more consistent with BDI_WRITTEN, which is used for bandwidth estimation.
CC: Michael Rubin <mrubin@google.com> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> --- mm/page-writeback.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
--- linux-next.orig/mm/page-writeback.c 2011-04-18 17:28:44.000000000 +0800 +++ linux-next/mm/page-writeback.c 2011-04-18 17:30:33.000000000 +0800 @@ -1846,7 +1846,6 @@ EXPORT_SYMBOL(account_page_dirtied); void account_page_writeback(struct page *page) { inc_zone_page_state(page, NR_WRITEBACK); - inc_zone_page_state(page, NR_WRITTEN); } EXPORT_SYMBOL(account_page_writeback); @@ -2063,8 +2062,10 @@ int test_clear_page_writeback(struct pag } else { ret = TestClearPageWriteback(page); } - if (ret) + if (ret) { dec_zone_page_state(page, NR_WRITEBACK); + inc_zone_page_state(page, NR_WRITTEN); + } return ret; }
| |