lkml.org 
[lkml]   [2011]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH]: block: try-2 (modified): Initialize bi_rw in mpage so bio_add can make use of it.
From
Jens et al,

do_mpage_readpage()/__mpage_writepage(): When they allocate a new bio,
bi_rw is not initialized. So later when they call __bio_add_page(),
struct bvec_merge_data bvm's .bi_rw will not be initialized with right
direction.
It will be useful for some merge functions if they know the direction
of transfer.

Let me know if this looks good. There are few more places like this
(e.g blkdev_issue_zeroout()). Would it make sense to send patch for
these cases also?

Signed-off-by: Muthukumar R <muthur@gmail.com>

------------------------
fs/mpage.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
------------------------
diff --git a/fs/mpage.c b/fs/mpage.c
index fdfae9f..efabfc0 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -291,6 +291,7 @@ alloc_new:
GFP_KERNEL);
if (bio == NULL)
goto confused;
+ bio->bi_rw = READ;
}

length = first_hole << blkbits;
@@ -583,6 +584,7 @@ alloc_new:
bio_get_nr_vecs(bdev), GFP_NOFS|__GFP_HIGH);
if (bio == NULL)
goto confused;
+ bio->bi_rw = WRITE;
}

/*

\
 
 \ /
  Last update: 2011-07-11 19:33    [W:0.380 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site