lkml.org 
[lkml]   [2011]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectstaging/lirc_bt829: Return -ENODEV when no hardware is found.
sys_init_module: 'lirc_bt829'->init suspiciously returned 1, it should follow 0/-E convention
sys_init_module: loading module anyway...
Pid: 8511, comm: modprobe Tainted: G WC 3.0.0-rc6+ #73
Call Trace:
[<ffffffff810b3da7>] sys_init_module+0x217/0x230
[<ffffffff815ed1d2>] system_call_fastpath+0x16/0x1b

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/drivers/staging/lirc/lirc_bt829.c b/drivers/staging/lirc/lirc_bt829.c
index 3388102..c5a0d27 100644
--- a/drivers/staging/lirc/lirc_bt829.c
+++ b/drivers/staging/lirc/lirc_bt829.c
@@ -122,10 +122,10 @@ int init_module(void)

pdev = do_pci_probe();
if (pdev == NULL)
- return 1;
+ return -ENODEV;

if (!atir_init_start())
- return 1;
+ return -ENODEV;

strcpy(atir_driver.name, "ATIR");
atir_driver.minor = -1;

\
 
 \ /
  Last update: 2011-07-11 17:27    [W:0.040 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site