Messages in this thread | | | Date | Fri, 1 Jul 2011 10:10:18 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH 08/11] misc: Kconfig and Makefile changes for inv_mpu driver |
| |
On Thu, 30 Jun 2011 19:18:24 -0700 Nathan Royer wrote:
> Signed-off-by: Nathan Royer <nroyer@invensense.com> > --- > drivers/misc/Kconfig | 1 + > drivers/misc/Makefile | 1 + > drivers/misc/inv_mpu/Kconfig | 58 +++++++++++++++++++++++++++++++++++++++++ > drivers/misc/inv_mpu/Makefile | 17 ++++++++++++ > 4 files changed, 77 insertions(+), 0 deletions(-) > create mode 100644 drivers/misc/inv_mpu/Kconfig > create mode 100644 drivers/misc/inv_mpu/Makefile > > diff --git a/drivers/misc/inv_mpu/Kconfig b/drivers/misc/inv_mpu/Kconfig > new file mode 100644 > index 0000000..fdfa7a6 > --- /dev/null > +++ b/drivers/misc/inv_mpu/Kconfig > @@ -0,0 +1,58 @@ > + > +menuconfig: INV_SENSORS
hm, that ':' there happens to work, but the syntax description for "menuconfig" does not show it as allowed, and no other Kconfig files use a colon there, so please drop it.
Oh, also not "default y", please.
> + tristate "Motion Processing Unit" > + depends on I2C > + default y > + > +if INV_SENSORS > + > +choice > + prompt "MPU Master" > + depends on I2C && INV_SENSORS > + default MPU_SENSORS_MPU3050 > + > +config MPU_SENSORS_MPU3050 > + bool "MPU3050" > + depends on I2C > + select MPU_SENSORS_MPU3050_GYRO > + help > + If you say yes here you get support for the MPU3050 Gyroscope driver > + This driver can also be built as a module. If so, the module > + will be called mpu3050. > + > +config MPU_SENSORS_MPU6050A2 > + bool "MPU6050A2" > + depends on I2C > + select MPU_SENSORS_MPU6050_GYRO > + help > + If you say yes here you get support for the MPU6050A2 Gyroscope driver > + This driver can also be built as a module. If so, the module > + will be called mpu6050a2. > + > +config MPU_SENSORS_MPU6050B1 > + bool "MPU6050B1" > + select MPU_SENSORS_MPU6050_GYRO > + depends on I2C > + help > + If you say yes here you get support for the MPU6050 Gyroscope driver > + This driver can also be built as a module. If so, the module > + will be called mpu6050b1. > + > +endchoice > + > +choice > + prompt "Gyroscope Type" > + depends on I2C && INV_SENSORS > + default MPU_SENSORS_MPU3050_GYRO > + > +config MPU_SENSORS_MPU3050_GYRO > + bool "MPU3050 built in gyroscope" > + depends on MPU_SENSORS_MPU3050 > + > +config MPU_SENSORS_MPU6050_GYRO > + bool "MPU6050 built in gyroscope" > + depends on MPU_SENSORS_MPU6050B1 || MPU_SENSORS_MPU6050A2 > + > +endchoice > + > +endif #INV_SENSORS
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
| |