Messages in this thread | | | Date | Tue, 24 May 2011 14:32:37 +0900 | Subject | Re: ramoops: is using platform_drivers correct? | From | Kyungmin Park <> |
| |
On Mon, May 23, 2011 at 11:36 PM, Kyungmin Park <kmpark@infradead.org> wrote: > Hi, > > You have to define the ramoops platform data at your board file and > pass it to the platform device init. > As these address is different for each SoCs. e.g., x86, and Samsung > ARM SoCs and so on. > > I think maybe you use the x86 so define the default x86 ram address > for ramoops and pass it to platform structures. > > At office, I will send the sample usage.
+static struct ramoops_platform_data goni_ramoops_data = { + .mem_size = SZ_16K, + .mem_address = 0xED000000, /* SRAM */ +}; + +static struct platform_device goni_ramoops = { + .name = "ramoops", + .dev = { + .platform_data = &goni_ramoops_data, + }, +};
and register the goni_rammoops. then you can find a rammops.
Thank you, Kyungmin Park
> > Thank you, > Kyungmin Park > > On Mon, May 23, 2011 at 11:10 PM, Américo Wang <xiyou.wangcong@gmail.com> wrote: >> On Mon, May 23, 2011 at 9:27 PM, Stevie Trujillo >> <stevie.trujillo@gmail.com> wrote: >>> Hello, >>> >>> ramoops (drivers/char/ramoops.c) is for "all" computers right? When I try to >>> load it on my laptop, I get ENODEV. This is caused by platform_driver_probe() >>> - the code never reaches the ramoops probe callback. >>> >>> After I removed the platform_driver stuff, moving everything into ramoops_init >>> and ramoops_exit it worked. >> >> Actually that was changed by Kyungmin, Cc'ing... >> >> commit c3b92ce9e75f6353104fc7f8e32fb9fdb2550ad0 >> Author: Kyungmin Park <kyungmin.park@samsung.com> >> Date: Wed Oct 27 15:34:52 2010 -0700 >> >> ramoops: use the platform data structure instead of module params >> >> As each board and system has different memory for ramoops. It's better to >> define the platform data instead of module params. >> >> [akpm@linux-foundation.org: fix ramoops_remove() return type] >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> Cc: Marco Stornelli <marco.stornelli@gmail.com> >> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> >> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |