Messages in this thread | | | Date | Mon, 23 May 2011 22:10:17 +0800 | Subject | Re: ramoops: is using platform_drivers correct? | From | Américo Wang <> |
| |
On Mon, May 23, 2011 at 9:27 PM, Stevie Trujillo <stevie.trujillo@gmail.com> wrote: > Hello, > > ramoops (drivers/char/ramoops.c) is for "all" computers right? When I try to > load it on my laptop, I get ENODEV. This is caused by platform_driver_probe() > - the code never reaches the ramoops probe callback. > > After I removed the platform_driver stuff, moving everything into ramoops_init > and ramoops_exit it worked.
Actually that was changed by Kyungmin, Cc'ing...
commit c3b92ce9e75f6353104fc7f8e32fb9fdb2550ad0 Author: Kyungmin Park <kyungmin.park@samsung.com> Date: Wed Oct 27 15:34:52 2010 -0700
ramoops: use the platform data structure instead of module params
As each board and system has different memory for ramoops. It's better to define the platform data instead of module params.
[akpm@linux-foundation.org: fix ramoops_remove() return type] Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> Cc: Marco Stornelli <marco.stornelli@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| |