lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 4/7] clockevents: Provide combined configure and register function

* Thomas Gleixner <tglx@linutronix.de> wrote:

> +extern void clockevents_config_and_register(struct clock_event_device *dev,
> + u32 freq, unsigned long min_delta,
> + unsigned long max_delta);

might be worth collecting these fields into a clocksource_params structure:

struct clocksource_params {
u32 freq;
unsigned long min_delta;
unsigned long max_delta;
};

That way the initialization API looks even more streamlined:

extern void
clockevents_config_and_register(struct clock_event_device *dev,
struct clocksource_params params);

and could be extended in the future, without having to update every single
clocksource driver again.

But a good first step in any case:

Reviewed-by: Ingo Molnar <mingo@elte.hu>

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-19 11:11    [W:0.115 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site