Messages in this thread | | | Date | Thu, 19 May 2011 11:37:06 +0200 | From | Ingo Molnar <> | Subject | Re: [patch 5/7] clockevents: Provide interface to reconfigure an active clock event device |
| |
* Thomas Gleixner <tglx@linutronix.de> wrote:
> On Thu, 19 May 2011, Ingo Molnar wrote: > > * Thomas Gleixner <tglx@linutronix.de> wrote: > > > + */ > > > +int clockevents_reconfigure(struct clock_event_device *dev, u32 freq) > > > > This too could use a struct clockevents_params perhaps - and would only use > > params.freq for now but might be extended in the future. > > > > But i'm fine with this API as well: > > I agree for the config_register interface, but here we really just > want to update the frequency and not change any other parameter.
ok, fair enough - in that case i'd suggest making that property explicitly visible in the API name, via something like:
int clockevents_set_freq(struct clock_event_device *dev, u32 freq)
That way it's obvious at first sight what this does:
clockevents_set_freq(dev, 1000000);
Versus:
clockevents_reconfigure(dev, 1000000);
Thanks,
Ingo
| |