lkml.org 
[lkml]   [2011]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver
On Thu, 19 May 2011 11:31:32 -0500
Timur Tabi <timur@freescale.com> wrote:

> Alan Cox wrote:
> > You really also need a hangup method so vhangup() does the right thing
> > and you can securely do logins etc and sessions on your console. As
> > you've got no hardware entangled in this and you already use tty_port
> > helpers the hangup helper will do the work for you.
>
> So all I need is this?
>
> static void ehv_bc_tty_hangup(struct tty_struct *ttys)
> {
> struct ehv_bc_data *bc = ttys->driver_data;
>
> tty_port_hangup(&bc->port);
> }
>
> I've noticed that some drivers flush their transmit buffers before calling
> tty_port_hangup(), but some others don't. Should I do this too? I don't know
> if hangup should be as quick as possible.

Doesn't matter too much. If you can flush it quickly then do so


\
 
 \ /
  Last update: 2011-05-19 19:27    [W:0.085 / U:1.424 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site