Messages in this thread | | | Date | Wed, 18 May 2011 12:26:47 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 2/2] trivial: Changed the printk loglevel when not able to allocate memory |
| |
On Wed, May 18, 2011 at 12:24:36PM +0100, Russell King - ARM Linux wrote: > On Wed, May 18, 2011 at 04:27:47PM +0530, anish singh wrote: > > Got it.So should i change both as KERN_WARN and resend? > > Much better would be to change it to pr_warn() or even > dev_warn(&dev->dev, ...).
Actually, make that pr_err() or dev_err(). Both printks in clcdfb_probe() are errors and so should be reported at error severity - they cause things to stop working and so they're not just a warning.
| |