Messages in this thread | | | Subject | Re: [PATCH 2/2] trivial: Changed the printk loglevel when not able to allocate memory | From | Catalin Marinas <> | Date | Wed, 18 May 2011 12:01:47 +0100 |
| |
On Wed, 2011-05-18 at 11:57 +0100, anish singh wrote: > On Wed, May 18, 2011 at 3:45 PM, Catalin Marinas <catalin.marinas@arm.com> wrote: > > On Wed, 2011-05-18 at 04:19 +0100, anish singh wrote: > > On Tue, May 17, 2011 at 11:13 PM, Catalin Marinas <catalin.marinas@arm.com> wrote: > > On 17 May 2011 18:29, anish <anish198519851985@gmail.com> wrote: > > > When not able to allocate memory we were using KERN_INFO as > > > log level in printk so changed to KERN_ERR > > > Signed-off-by: anish kumar<anish198519851985@gmail.com> > > > > > > Maybe KERN_WARN? > > Then shouldn't we change below case also? > > 467 ret = amba_request_regions(dev, NULL); > > 468 if (ret) { > > 469 printk(KERN_ERR "CLCD: unable to reserve regs region\n"); > > 470 goto out; > > > > If yes,then i will resend the patch for this also. > > > I think the register reserving is less likely to fail because of memory > allocations but more because of overlapping regions, in which case it > could be a programming error. > > Allocating a big framebuffer is likely to fail in some memory constraint > systems but I don't consider this a kernel error. That's why I suggested > warning. > > Got it.So should i change both as KERN_WARN and resend?
No, just the one KERN_INFO one. Anyway, Russell King is the maintainer of this driver so it's up to him to ack the patch (and don't forget to cc him).
-- Catalin
| |