Messages in this thread | | | Date | Wed, 11 May 2011 16:55:20 +0900 | From | Hidetoshi Seto <> | Subject | Re: [patch 01/15] sched: (fixlet) dont update shares twice on on_rq parent |
| |
(2011/05/10 17:32), Mike Galbraith wrote: > On Tue, 2011-05-10 at 16:14 +0900, Hidetoshi Seto wrote: >> This small fixlet can stand alone. >> Peter, how about getting this into git tree first? > > tip 2f36825b176f67e5c5228aa33d828bc39718811f contains the below. > > /* Don't dequeue parent if it has other entities besides us */ > - if (cfs_rq->load.weight) > + if (cfs_rq->load.weight) { > + /* > + * Bias pick_next to pick a task from this cfs_rq, as > + * p is sleeping when it is within its sched_slice. > + */ > + if (task_sleep && parent_entity(se)) > + set_next_buddy(parent_entity(se)); > break; > + } > flags |= DEQUEUE_SLEEP; > }
Oh, thanks Mike! It seems that this change in tip is better one.
Paul, don't you mind rebasing your patches onto tip/sched/core next time? (...or is there better branch for rebase?)
Thanks, H.Seto
| |