Messages in this thread | | | Subject | Re: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver | From | Joe Perches <> | Date | Fri, 08 Apr 2011 12:55:54 -0700 |
| |
On Fri, 2011-04-08 at 21:46 +0200, Rafał Miłecki wrote: > 2011/4/8 Joe Perches <joe@perches.com>: > > On Fri, 2011-04-08 at 21:45 +0200, Rafał Miłecki wrote: > >> diff --git a/include/linux/axi/axi.h b/include/linux/axi/axi.h > > [] > >> +#define axi_info pr_info > >> +#ifdef CONFIG_AXI_DEBUG > >> +#define axi_debug pr_debug > >> +#else > >> +#define axi_debug do { } while (0) > >> +#endif > >> +#define axi_err pr_err > > > > I think redefining standard functionality like > > this doesn't gain anything and loses some basic > > grep capability. > > But on the other hand using: > pr_info, pr_err, BUT axi_debug > can easily lead to mistakes. > > Or is this possible to re-define pr_debug locally?
It is, but is that CONFIG_AXI_DEBUG actually worthwhile?
If you think so, doesn't adding this to the Makefile give you the same capability?
ccflags-$(CONFIG_CONFIG_AXI_DEBUG) := -DDEBUG
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |