Messages in this thread | | | Date | Fri, 8 Apr 2011 21:46:19 +0200 | Subject | Re: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver | From | Rafał Miłecki <> |
| |
2011/4/8 Joe Perches <joe@perches.com>: > On Fri, 2011-04-08 at 21:45 +0200, Rafał Miłecki wrote: >> diff --git a/include/linux/axi/axi.h b/include/linux/axi/axi.h > [] >> +#define axi_info pr_info >> +#ifdef CONFIG_AXI_DEBUG >> +#define axi_debug pr_debug >> +#else >> +#define axi_debug do { } while (0) >> +#endif >> +#define axi_err pr_err > > I think redefining standard functionality like > this doesn't gain anything and loses some basic > grep capability.
But on the other hand using: pr_info, pr_err, BUT axi_debug can easily lead to mistakes.
Or is this possible to re-define pr_debug locally?
-- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |