lkml.org 
[lkml]   [2011]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver
From
2011/4/8 Joe Perches <joe@perches.com>:
> On Fri, 2011-04-08 at 21:45 +0200, Rafał Miłecki wrote:
>> diff --git a/include/linux/axi/axi.h b/include/linux/axi/axi.h
> []
>> +#define axi_info     pr_info
>> +#ifdef CONFIG_AXI_DEBUG
>> +#define axi_debug    pr_debug
>> +#else
>> +#define axi_debug    do { } while (0)
>> +#endif
>> +#define axi_err              pr_err
>
> I think redefining standard functionality like
> this doesn't gain anything and loses some basic
> grep capability.

But on the other hand using:
pr_info, pr_err, BUT axi_debug
can easily lead to mistakes.

Or is this possible to re-define pr_debug locally?

--
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-04-08 21:49    [W:0.066 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site