lkml.org 
[lkml]   [2011]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[36/55] [PARISC] slub: fix panic with DISCONTIGMEM
    2.6.38-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: James Bottomley <James.Bottomley@HansenPartnership.com>

    commit 4a5fa3590f09999f6db41bc386bce40848fa9f63 upstream.

    Slub makes assumptions about page_to_nid() which are violated by
    DISCONTIGMEM and !NUMA. This violation results in a panic because
    page_to_nid() can be non-zero for pages in the discontiguous ranges and
    this leads to a null return by get_node(). The assertion by the
    maintainer is that DISCONTIGMEM should only be allowed when NUMA is also
    defined. However, at least six architectures: alpha, ia64, m32r, m68k,
    mips, parisc violate this. The panic is a regression against slab, so
    just mark slub broken in the problem configuration to prevent users
    reporting these panics.

    Acked-by: David Rientjes <rientjes@google.com>
    Acked-by: Pekka Enberg <penberg@kernel.org>
    Signed-off-by: James Bottomley <James.Bottomley@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    init/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    --- a/init/Kconfig
    +++ b/init/Kconfig
    @@ -1209,6 +1209,7 @@ config SLAB
    per cpu and per node queues.

    config SLUB
    + depends on BROKEN || NUMA || !DISCONTIGMEM
    bool "SLUB (Unqueued Allocator)"
    help
    SLUB is a slab allocator that minimizes cache line usage



    \
     
     \ /
      Last update: 2011-04-29 21:05    [W:0.018 / U:1.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site