[lkml]   [2011]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[39/55] virtio: console: Enable call to hvc_remove() on console port remove
    2.6.38-stable review patch.  If anyone has any objections, please let us know.


    From: Amit Shah <>

    commit afa2689e19073cd2e762d0f2c1358fab1ab9f18c upstream.

    This call was disabled as hot-unplugging one virtconsole port led to
    another virtconsole port freezing.

    Upon testing it again, this now works, so enable it.

    In addition, a bug was found in qemu wherein removing a port of one type
    caused the guest output from another port to stop working. I doubt it
    was just this bug that caused it (since disabling the hvc_remove() call
    did allow other ports to continue working), but since it's all solved
    now, we're fine with hot-unplugging of virtconsole ports.

    Signed-off-by: Amit Shah <>
    Signed-off-by: Rusty Russell <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/char/virtio_console.c | 11 -----------
    1 file changed, 11 deletions(-)

    --- a/drivers/char/virtio_console.c
    +++ b/drivers/char/virtio_console.c
    @@ -1280,18 +1280,7 @@ static void unplug_port(struct port *por
    -#if 0
    - /*
    - * hvc_remove() not called as removing one hvc port
    - * results in other hvc ports getting frozen.
    - *
    - * Once this is resolved in hvc, this functionality
    - * will be enabled. Till that is done, the -EPIPE
    - * return from get_chars() above will help
    - * hvc_console.c to clean up on ports we remove here.
    - */

    /* Remove unused data this port might have received. */

     \ /
      Last update: 2011-04-29 21:01    [W:0.019 / U:38.380 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site