lkml.org 
[lkml]   [2011]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow
    On 04/21/2011 05:17 PM, Ingo Molnar wrote:
    >
    > * Don Zickus <dzickus@redhat.com> wrote:
    >
    >> On Wed, Apr 20, 2011 at 07:13:37PM +0400, Cyrill Gorcunov wrote:
    >>> It's not enough to simply disable event on overflow the cpuc->active_mask
    >>> should be cleared as well otherwise counter may stall in "active" even
    >>> in real being already disabled (which potentially may lead to the situation
    >>> that user may not use this counter further).
    >>
    >> I also noticed this patch fixed some unknown NMIs on a P4 when I stressed
    >> the box
    >>
    >> Acked-by: Don Zickus <dzickus@redhat.com>
    >
    > Ok. Mind one of you resending all pending patches in this area, with all
    > Acked-by's and Tested-by's in place?
    >
    > I'd like to ask one more thing as well: please submit the patches in a single
    > e-mail thread - i.e. with a proper 0/N and e-mail threading, so that anyone can
    > see that they are a group of patches. Current submissions are various versions
    > of patches with no clear grouping.
    >
    > Thanks,
    >
    > Ingo

    Don, will you pick it up in addition to your unknown NMI fast-fix?

    --
    Cyrill


    \
     
     \ /
      Last update: 2011-04-21 16:01    [W:0.021 / U:31.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site