lkml.org 
[lkml]   [2011]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask on overflow
On Thu, Apr 21, 2011 at 03:17:48PM +0200, Ingo Molnar wrote:
>
> * Don Zickus <dzickus@redhat.com> wrote:
>
> > On Wed, Apr 20, 2011 at 07:13:37PM +0400, Cyrill Gorcunov wrote:
> > > It's not enough to simply disable event on overflow the cpuc->active_mask
> > > should be cleared as well otherwise counter may stall in "active" even
> > > in real being already disabled (which potentially may lead to the situation
> > > that user may not use this counter further).
> >
> > I also noticed this patch fixed some unknown NMIs on a P4 when I stressed
> > the box
> >
> > Acked-by: Don Zickus <dzickus@redhat.com>
>
> Ok. Mind one of you resending all pending patches in this area, with all
> Acked-by's and Tested-by's in place?

Cyril is that something you can do because I think all of these patches
revolve around P4 fixes? Though I don't know what are all the patches. I
know I had one and this patch. Is there another on Cyril?

Cheers,
Don


\
 
 \ /
  Last update: 2011-04-21 16:01    [from the cache]
©2003-2011 Jasper Spaans