lkml.org 
[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[48/74] econet: 4 byte infoleak to the network
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Vasiliy Kulikov <segoon@openwall.com>

    commit 67c5c6cb8129c595f21e88254a3fc6b3b841ae8e upstream.

    struct aunhdr has 4 padding bytes between 'pad' and 'handle' fields on
    x86_64. These bytes are not initialized in the variable 'ah' before
    sending 'ah' to the network. This leads to 4 bytes kernel stack
    infoleak.

    This bug was introduced before the git epoch.

    Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
    Acked-by: Phil Blundell <philb@gnu.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/econet/af_econet.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/econet/af_econet.c
    +++ b/net/econet/af_econet.c
    @@ -428,10 +428,10 @@ static int econet_sendmsg(struct kiocb *
    udpdest.sin_addr.s_addr = htonl(network | addr.station);
    }

    + memset(&ah, 0, sizeof(ah));
    ah.port = port;
    ah.cb = cb & 0x7f;
    ah.code = 2; /* magic */
    - ah.pad = 0;

    /* tack our header on the front of the iovec */
    size = sizeof(struct aunhdr);



    \
     
     \ /
      Last update: 2011-04-13 18:05    [W:0.028 / U:59.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site