lkml.org 
[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[62/74] atm/solos-pci: Dont include frame pseudo-header on transmit hex-dump
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Philip A. Prindeville <philipp@redfish-solutions.com>

    commit 18b429e74eeafe42e947b1b0f9a760c7153a0b5c upstream.

    Omit pkt_hdr preamble when dumping transmitted packet as hex-dump;
    we can pull this up because the frame has already been sent, and
    dumping it is the last thing we do with it before freeing it.

    Also include the size, vpi, and vci in the debug as is done on
    receive.

    Use "port" consistently instead of "device" intermittently.

    Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/atm/solos-pci.c | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    --- a/drivers/atm/solos-pci.c
    +++ b/drivers/atm/solos-pci.c
    @@ -688,7 +688,7 @@ void solos_bh(unsigned long card_arg)
    size);
    }
    if (atmdebug) {
    - dev_info(&card->dev->dev, "Received: device %d\n", port);
    + dev_info(&card->dev->dev, "Received: port %d\n", port);
    dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
    size, le16_to_cpu(header->vpi),
    le16_to_cpu(header->vci));
    @@ -1008,8 +1008,15 @@ static uint32_t fpga_tx(struct solos_car

    /* Clean up and free oldskb now it's gone */
    if (atmdebug) {
    + struct pkt_hdr *header = (void *)oldskb->data;
    + int size = le16_to_cpu(header->size);
    +
    + skb_pull(oldskb, sizeof(*header));
    dev_info(&card->dev->dev, "Transmitted: port %d\n",
    port);
    + dev_info(&card->dev->dev, "size: %d VPI: %d VCI: %d\n",
    + size, le16_to_cpu(header->vpi),
    + le16_to_cpu(header->vci));
    print_buffer(oldskb);
    }




    \
     
     \ /
      Last update: 2011-04-13 18:01    [W:0.023 / U:33.780 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site