Messages in this thread Patch in this message | | | From | Liu Yuan <> | Subject | [PATCH] drivers/infiniband: Add a check for strict_strtoul() | Date | Fri, 1 Apr 2011 14:23:49 +0800 |
| |
From: Liu Yuan <tailai.ly@taobao.com>
It should check if strict_strtoul() succeeds before using 'wqm_quanta_value'.
Signed-off-by: Liu Yuan <tailai.ly@taobao.com> --- drivers/infiniband/hw/nes/nes.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c index 13de119..119d60d 100644 --- a/drivers/infiniband/hw/nes/nes.c +++ b/drivers/infiniband/hw/nes/nes.c @@ -1138,7 +1138,9 @@ static ssize_t nes_store_wqm_quanta(struct device_driver *ddp, u32 i = 0; struct nes_device *nesdev; - strict_strtoul(buf, 0, &wqm_quanta_value); + if (strict_strtoul(buf, 0, &wqm_quanta_value) < 0) + return -EINVAL; + list_for_each_entry(nesdev, &nes_dev_list, list) { if (i == ee_flsh_adapter) { nesdev->nesadapter->wqm_quanta = wqm_quanta_value; -- 1.7.1
| |