Messages in this thread | | | Date | Mon, 7 Mar 2011 09:25:34 -0500 | From | Chris Metcalf <> | Subject | Re: [PATCH] futex: cmpxchg_futex_value_locked API change |
| |
On 3/6/2011 9:11 PM, Michel Lespinasse wrote: > The cmpxchg_futex_value_locked API was funny in that it returned either > the original, user-exposed futex value OR an error code such as -EFAULT. > This was confusing at best, and could be a source of livelocks in places > that retry the cmpxchg_futex_value_locked after trying to fix the issue > by running fault_in_user_writeable(). > > This change makes the cmpxchg_futex_value_locked API more similar to the > get_futex_value_locked one, returning an error code and updating the > original value through a reference argument. > [...] > diff --git a/arch/tile/include/asm/futex.h b/arch/tile/include/asm/futex.h
Makes sense to me; that API is a little crazy.
For the tile changes:
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
-- Chris Metcalf, Tilera Corp. http://www.tilera.com
| |