Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] futex: cmpxchg_futex_value_locked API change | Date | Wed, 09 Mar 2011 12:41:27 +0000 |
| |
Michel Lespinasse <walken@google.com> wrote:
> The cmpxchg_futex_value_locked API was funny in that it returned either > the original, user-exposed futex value OR an error code such as -EFAULT. > This was confusing at best, and could be a source of livelocks in places > that retry the cmpxchg_futex_value_locked after trying to fix the issue > by running fault_in_user_writeable(). > > This change makes the cmpxchg_futex_value_locked API more similar to the > get_futex_value_locked one, returning an error code and updating the > original value through a reference argument. > > Signed-off-by: Michel Lespinasse <walken@google.com>
Acked-by: David Howells <dhowells@redhat.com> [FRV]
| |