Messages in this thread | | | From | "Guan Xuetao" <> | Subject | RE: [PATCH] unicore32 framebuffer driver fix: make videomemory kmalloc-ed and floatable | Date | Tue, 29 Mar 2011 22:54:27 +0800 |
| |
> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Tuesday, March 29, 2011 10:43 PM > To: Guan Xuetao > Cc: Paul Mundt; linux-kernel@vger.kernel.org; linux-fbdev@vger.kernel.org > Subject: Re: [PATCH] unicore32 framebuffer driver fix: make videomemory kmalloc-ed and floatable > > On Tuesday 29 March 2011, Guan Xuetao wrote: > > > > 1. make videomemory kmalloc-ed in fb-puv3.c > > 2. remove resource reservation for old fixed UNIGFX_MMAP & UVC_MMAP space > > 3. remove unused PKUNTIY_UNIGFX_MMAP_BASE, PKUNITY_UNIGFX_MMAP_SIZE, > > PKUNITY_UVC_MMAP_BASE, PKUNITY_UVC_MMAP_SIZE and KUSER_UNIGFX_BASE > > 4. remove unused header linux/vmalloc.h in fb-puv3.c > > > > Signed-off-by: Guan Xuetao <gxt@mprc.pku.edu.cn> > > How does this work? UNIFB_MEMSIZE seems to be 4 MB, much more than the > maximum of 128 KB that kmalloc can allocate. I'm surprised. But kmalloc() returns success with 0xc7000000.
> > Shouldn't this use get_free_pages() instead of kmalloc?
I will check and correct it.
> > Arnd
Thanks.
Guan Xuetao
| |